[PATCH] media: raspberrypi: Fix error handling for media_entity_remote_source_pad_unique()
From: Triet Hoang
Date: Fri Sep 18 2026 - 02:49:14 EST
The media_entity_remote_source_pad_unique() function returns an error
pointer on failure, not NULL. Fix the check to use IS_ERR() and return
PTR_ERR() to correctly handle allocation failures.
Fixes: 6edb685abb2a ("media: raspberrypi: Add support for RP1-CFE")
Signed-off-by: Triet Hoang <triet.hoang.dev@xxxxxxxxx>
---
drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
index 8375ed3e97b9..91e9fa0341e0 100644
--- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
+++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
@@ -1779,7 +1779,7 @@ static int cfe_video_link_validate(struct media_link *link)
link->source->entity->name, link->source->index,
link->sink->entity->name, link->sink->index);
- if (!media_entity_remote_source_pad_unique(link->sink->entity)) {
+ if (IS_ERR(media_entity_remote_source_pad_unique(link->sink->entity))) {
cfe_err(cfe, "video node %s pad not connected\n", vd->name);
return -ENOTCONN;
}
--
2.53.0