Re: [PATCH v4 01/10] dmaengine: Move enum dma_slave_buswidth to a new header
From: Andy Shevchenko
Date: Fri Sep 18 2026 - 02:30:21 EST
On Thu, Sep 17, 2026 at 11:39:54PM +0530, Vinod Koul wrote:
> On 15-09-26, 12:04, Frank Li wrote:
> > On Tue, Sep 15, 2026 at 09:50:22PM +0530, Vinod Koul wrote:
> > > On 15-09-26, 21:22, Vinod Koul wrote:
...
> > > > > Traditional naming would be
> > > > > dma/engine/provider.h
(Actually majority of the subsystems use driver.h.)
> > > > > dma/engine/consumer.h
> > > >
> > > > consumer and provider and good names.. I would retain the full dmaengine
> > > > everywhere please. dma causes confusion already!
> > >
> > > Thinking about it again, drivers/dma/dmaengine.h should be the provider
> >
> > There some dmaengine code outside drivers/dma directory, like
> > drivers/crypto/ccp/ccp-dmaengine.c
>
> They chose to be outside, their choice... They need to be updated as
> well to point to ../../dma/dmaengine.h :-)
Hmm... It's rare to make such a requirement in the kernel for the resources
like this. All I know about (GPIO, regulator, pwrseq, IIO), they split and
provide the interfaces to the whole kernel.
--
With Best Regards,
Andy Shevchenko