RE: [EXTERNAL] Re: [PATCH] octeontx2-af: remove duplicate SCTP port flags

From: Geethasowjanya Akula

Date: Fri Sep 18 2026 - 02:14:34 EST




>-----Original Message-----
>From: TechyMinati <sinha.aryan03@xxxxxxxxx>
>Sent: Friday, September 18, 2026 11:36 AM
>To: Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; Ratheesh Kannoth
><rkannoth@xxxxxxxxxxx>; Geethasowjanya Akula <gakula@xxxxxxxxxxx>;
>Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxxx>
>Cc: Andrew Lunn <andrew+netdev@xxxxxxx>; davem@xxxxxxxxxxxxx;
>edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx;
>netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Subject: [EXTERNAL] Re: [PATCH] octeontx2-af: remove duplicate SCTP port
>flags
>
>This targets net-next. Sorry for the missing subject tag.
>
>On Fri, Sep 18, 2026 at 11:33 AM Aryan Sinha <sinha.aryan03@xxxxxxxxx
><mailto:sinha.aryan03@xxxxxxxxx> > wrote:
>
>
> proto_flags ORs BIT_ULL(NPC_SPORT_SCTP) and
>BIT_ULL(NPC_DPORT_SCTP)
> are present twice. Both fields are already covered by the first pair, so
>the second
> one has no effect.
>
> Drop it. No functional change.
>
> Signed-off-by: Aryan Sinha <sinha.aryan03@xxxxxxxxx
><mailto:sinha.aryan03@xxxxxxxxx> >
> ---
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
>b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
> index d422bdd5e..ec004ea51 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
> @@ -698,7 +698,6 @@ static void npc_set_features(struct rvu *rvu, int
>blkaddr, u8 intf)
> proto_flags = BIT_ULL(NPC_SPORT_TCP) |
>BIT_ULL(NPC_SPORT_UDP) |
> BIT_ULL(NPC_DPORT_TCP) | BIT_ULL(NPC_DPORT_UDP) |
> BIT_ULL(NPC_SPORT_SCTP) | BIT_ULL(NPC_DPORT_SCTP)
>|
> - BIT_ULL(NPC_SPORT_SCTP) | BIT_ULL(NPC_DPORT_SCTP)
>|
> BIT_ULL(NPC_TYPE_ICMP) | BIT_ULL(NPC_CODE_ICMP) |
> BIT_ULL(NPC_TCP_FLAGS);
>
> --
> 2.46.0
>
>
Reviewed-by: Geetha sowjanya <gakula@xxxxxxxxxxx>