Re: [PATCH 10/10] media: rcar-fcp: Add R-Car X5H support

[Laurent Pinchart]

On Thu, Sep 17, 2026 at 09:04:49PM +0900, Paul Elder wrote:

Same comment about authorship.

> The FCP instances found in the R-Car X5H v1.0 have a different device
> ID. Add it to the devices list.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> Signed-off-by: Paul Elder <paul.elder+renesas@xxxxxxxxxxxxxxxx>
> ---
>  drivers/media/platform/renesas/rcar-fcp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/platform/renesas/rcar-fcp.c b/drivers/media/platform/renesas/rcar-fcp.c
> index 15bcbbda3b853f71780aae876f6440b33addf193..8d62f07d38b7881270e94331b0564e4665664646 100644
> --- a/drivers/media/platform/renesas/rcar-fcp.c
> +++ b/drivers/media/platform/renesas/rcar-fcp.c
> @@ -33,6 +33,7 @@
>  #define RCAR_FCP_REG_VCR_REVISION_M3N		(6 << 0)
>  #define RCAR_FCP_REG_VCR_REVISION_V3H		(7 << 0)
>  #define RCAR_FCP_REG_VCR_REVISION_E3		(8 << 0)
> +#define RCAR_FCP_REG_VCR_REVISION_X5H_V1	(12 << 0)
>  
>  #define RCAR_FCP_REG_CFG0			0x0004
>  #define RCAR_FCP_REG_CFG0_FCPVSEL		BIT(1)
> @@ -223,6 +224,7 @@ static int rcar_fcp_setup(struct rcar_fcp_device *fcp)
>  		{ RCAR_FCP_REG_VCR_CATEGORY | RCAR_FCP_REG_VCR_REVISION_M3N, "M3N" },
>  		{ RCAR_FCP_REG_VCR_CATEGORY | RCAR_FCP_REG_VCR_REVISION_V3H, "V3H" },
>  		{ RCAR_FCP_REG_VCR_CATEGORY | RCAR_FCP_REG_VCR_REVISION_E3, "E3" },
> +		{ RCAR_FCP_REG_VCR_CATEGORY | RCAR_FCP_REG_VCR_REVISION_X5H_V1, "X5H v1.0" },
>  	};
>  
>  	unsigned int i;

-- 
Regards,

Laurent Pinchart