Re: [PATCH v2] irqchip: st: Convert to DEFINE_SIMPLE_DEV_PM_OPS()

[Radu Rendec]

On Thu, 2026-09-17 at 08:38 +0700, Triet Hoang wrote:
> Convert the deprecated SIMPLE_DEV_PM_OPS to DEFINE_SIMPLE_DEV_PM_OPS
> and pm_sleep_ptr().
> 
> This allows dropping the __maybe_unused annotations from the PM callbacks,
> also reduces kernel size in case CONFIG_PM or CONFIG_PM_SLEEP is disabled.
> 
> Signed-off-by: Triet Hoang <triet.hoang.dev@xxxxxxxxx>
> ---
> v2:
> - Address the commit message following reviewer's feedback
> 
> v1: https://lore.kernel.org/all/20260821043928.123543-1-triet.hoang.dev@xxxxxxxxx/
> ---
>  drivers/irqchip/irq-st.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-st.c b/drivers/irqchip/irq-st.c
> index de71bb350d57..fef0521831aa 100644
> --- a/drivers/irqchip/irq-st.c
> +++ b/drivers/irqchip/irq-st.c
> @@ -157,7 +157,7 @@ static int st_irq_syscfg_probe(struct platform_device *pdev)
>  	return st_irq_syscfg_enable(pdev);
>  }
>  
> -static int __maybe_unused st_irq_syscfg_resume(struct device *dev)
> +static int st_irq_syscfg_resume(struct device *dev)
>  {
>  	struct st_irq_syscfg *ddata = dev_get_drvdata(dev);
>  
> @@ -165,12 +165,12 @@ static int __maybe_unused st_irq_syscfg_resume(struct device *dev)
>  				  ST_A9_IRQ_MASK, ddata->config);
>  }
>  
> -static SIMPLE_DEV_PM_OPS(st_irq_syscfg_pm_ops, NULL, st_irq_syscfg_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(st_irq_syscfg_pm_ops, NULL, st_irq_syscfg_resume);
>  
>  static struct platform_driver st_irq_syscfg_driver = {
>  	.driver = {
>  		.name = "st_irq_syscfg",
> -		.pm = &st_irq_syscfg_pm_ops,
> +		.pm = pm_sleep_ptr(&st_irq_syscfg_pm_ops),
>  		.of_match_table = st_irq_syscfg_match,
>  	},
>  	.probe = st_irq_syscfg_probe,
> --
> 2.53.0

Reviewed-by: Radu Rendec <radu@xxxxxxxxxx>