Re: [PATCH net-next v2] netlink: specs: fix duplicate if/then keys in netlink-raw schema

From: tmbates12

Date: Thu Sep 17 2026 - 19:59:27 EST


On Thu, 17 Sep 2026 09:35:07 +0100, Donald Hunter wrote:
> Good catch. We have a lint check on the specs but not the schemas. Maybe
> need to add that.

Agreed, there definitely is a gap there, as tools/net/ynl/Makefile is
only pulling in yaml from the specs dir:

SPECDIR=../../../Documentation/netlink/specs
lint:
yamllint $(SPECDIR)

The default profile is rather noisy on the schemas, with both errors
and warnings, mostly brackets, line-length and truthy. With this patch
applied:

$ yamllint -f parsable Documentation/netlink/*.yaml | wc -l
460
$ yamllint -f parsable Documentation/netlink/*.yaml | grep -c '\[error\]'
386

So it'd be worth having a .yamllint config scoped just for the schemas
so we're not chasing a bunch of smaller things, while still checking
for any structure breaking ones (such as the one addressed in this
patch). I'd be happy to put this together as a follow-up if that
sounds useful.