Re: [PATCH v3 10/20] kbuild: move the toolchain checks into init/Kconfig.toolchain

[Kees Cook]

On Thu, Sep 17, 2026 at 05:06:20PM +0100, Lorenzo Stoakes (ARM) wrote:
> Move them into their own file, sourced from the top of init/Kconfig, so
> that the next commit can add to them without growing init/Kconfig further.
> 
> No functional change.
> 
> Assisted-by: LLM
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>
> ---
>  init/Kconfig           | 197 +-----------------------------------------------
>  init/Kconfig.toolchain | 198 +++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 199 insertions(+), 196 deletions(-)

Yeah, totally right to move to a separate file. I think, however, I
would prefer this wasn't in init/ though. Kbuild uses scripts/ as its
Makefile.$topic dumping ground, and Kconfig.include also lives there. To
me, this new file should be scripts/Kconfig.toolchain instead. And
arguably, this should be included by the top-level Kconfig rather than
init/Kconfig...

I defer to kbuild folks, though.

-Kees

-- 
Kees Cook