Re: [PATCH 5/5] hwmon: (nct6683) Enable pwm control on ASRock B850 Steel Legend WiFi

From: Guenter Roeck

Date: Thu Sep 17 2026 - 17:09:24 EST

On 9/17/26 10:35, Fabio Baltieri wrote:
Hi,

On Tue, Aug 25, 2026 at 11:25:46AM +0200, Johan Dahlin wrote:
Fan control has been measured on this board: with a fan in manual mode the
applied pwm value tracks what is written, and the fan responds
proportionally from 337 RPM at pwm 60 to 933 RPM at pwm 255.

Allow pwm writes on this board.

Signed-off-by: Johan Dahlin <jdahlin@xxxxxxxxx>
---
drivers/hwmon/nct6683.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index 6825e6c3af34..df28055b1a1c 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -972,7 +972,8 @@ SENSOR_TEMPLATE(pwm, "pwm%d", S_IRUGO, show_pwm, store_pwm, 0);
*/
static bool nct6683_has_fan_control(struct nct6683_data *data)
{
- return data->customer_id == NCT6683_CUSTOMER_ID_MITAC;
+ return data->customer_id == NCT6683_CUSTOMER_ID_MITAC ||
+ data->customer_id == NCT6683_CUSTOMER_ID_ASROCK8;
}
/*

Thanks for the patches, I tried this on an ASRock BC-250, also NCT6686D,
and it works fine there as well. The board id is
NCT6683_CUSTOMER_ID_AMD and all it needed was:

- data->customer_id == NCT6683_CUSTOMER_ID_ASROCK8;
+ data->customer_id == NCT6683_CUSTOMER_ID_ASROCK8 ||
+ data->customer_id == NCT6683_CUSTOMER_ID_AMD;

Maybe you can add that as well once you send the v2 of this? (and a
Tested-by: Fabio Baltieri <fabio.baltieri@xxxxxxxxx>). Or I'm happy to
send a followup myself once this gets merged, whatever you prefer.

Either way I feel like this list is going to grow, maybe a

switch (data->customer_id) {
...

would work out better long term here.

Or maybe add a boolean have_fan_control or similar to struct nct6683_data,
populate it in the probe function, and just use it.

Thanks,
Guenter