Re: [PATCHv2 net-next] net: fec_mpc52xx: remove dead resource size check
From: Rosen Penev
Date: Thu Sep 17 2026 - 14:50:18 EST
On Thu, Sep 17, 2026 at 7:56 AM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> On Wed, Sep 16, 2026 at 03:32:28PM -0700, Rosen Penev wrote:
> > The check bails out if the FEC register resource is smaller than
> > sizeof(struct mpc52xx_fec), but every in-tree device tree describes
> > the FEC node as a 0x400 byte region, which is exactly the size of the
> > struct, so the condition can never be true.
>
> We generally don't fully trust DT blobs.
>
> Does this test do any actual harm in its current state?
> Why remove it?
Previous discussion:
https://lore.kernel.org/netdev/20260518044047.1002235-1-rosenp@xxxxxxxxx/
>
> Andrew