Re: [PATCH net v7 1/2] net: stmmac: selftests: Prevent RXC from being disabled in LPI

[Maxime Chevallier]

Hi

On 9/17/26 17:08, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider:
> 
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
> 
> - [Medium] The last paragraph of the commit message describes the
>   `eee_rx_clk_stop_enable` precondition backwards.
> 
> --
> 
> net: stmmac: selftests: Prevent RXC from being disabled in LPI
> 
> The patch wraps the selftest loop in stmmac_selftest_run() with
> phylink_rx_clk_stop_block() / phylink_rx_clk_stop_unblock() so the PHY
> does not stop the receive clock while the MAC is in loopback. The code
> change itself looks balanced and is a no-op when the phylink config does
> not allow RX clock stop.
> 
> The question below is only about the changelog, so the diff hunk is not
> quoted.
> 
>>     As the NETIF_F_VLAN_FEATURES may be empty on some platforms once the
>>     software vlan stripping is removed, the phylink config attribute
>>     'eee_rx_clk_stop_enable' may no longer be inconditionnally set to
>>     true, hence allowing RXC to be disabled during LPI on platforms
>>     that don't have any VLAN features.
> 
> [Severity: Medium]
> Is the true/false direction here inverted?

Yeah should say "eee_rx_clk_stop_enable' may no longer be unconditionnally
set to false", my bad...

Code is correct though.
> 
> Related to that, should the changelog also mention that
> CONFIG_VLAN_8021Q=n builds are already affected today? 
I'm fine with it.

Peilin He, are you ok with changing the commit log if you send another
iteration ?

Thanks for you work and for including this patch :)

Maxime