Re: [PATCH 12/13] vfio/nvidia-vgpu: add the NVIDIA vGPU VFIO variant driver

From: Danilo Krummrich

Date: Thu Sep 17 2026 - 11:46:02 EST


On Thu Sep 17, 2026 at 3:28 PM CEST, Jason Gunthorpe wrote:
> On Wed, Sep 16, 2026 at 08:02:17PM +0200, Danilo Krummrich wrote:
>> >> TBH, I don't think it makes a difference; having Rust abstractions is pretty
>> >> much the same as having another driver. I.e. it would be equivalent to saying
>> >> "before we accept another pci-vfio driver we need to do some rework".
>> >
>> > Well, it is, but thats the point when judging effort..
>>
>> So it seems that we agree that there isn't really a difference between adding a
>> new C or Rust driver in this regard.
>
> To be clear I was trying to say I think you are are underestimating
> how much work this is and how long it will take. Including all the
> preconditon C reworks has to be included when considering how much
> work is involved.

I'm not sure I follow what you mean by "preconditon C reworks".

Do you refer to the drvdata thing? That seems rather trivial to address?

Or do you refer to other C core reworks people are working on? If so, they are
only relevant if they affect the drivers. And if they affect the drivers,
there's not really a difference between adding a new C driver and adding a Rust
abstraction.

> Why can't we just go forward with what Zhi already drafted? Do we
> really need another side quest?

Because I don't think it is a side quest. As mentioned, the FFI layer is already
more complicated than the Rust abstraction we need, and I also don't see that
this work is progressed further than the Rust abstraction I drafted. So, why not
just go for the proper solution right away?

I still have to finish some talks, but I could probably finish that work until
LPC and then we can walk through it?

> I cannot forsee rust bindings for vfio until sometime in 2027.

What is different in 2027 than is now?