Re: [PATCH v2 02/19] clk: qcom: Add global clock controller driver for MSM8952

[Muzaffer Kadir]

Hi Taniya,

On Thu, 17 Sep 2026 09:49:07 +0530, Taniya Das wrote:
>> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile
>> index a6c676f68b79..3c3f27dcc68d 100644
>> --- a/drivers/clk/qcom/Makefile
>> +++ b/drivers/clk/qcom/Makefile
>> @@ -89,6 +89,7 @@ obj-$(CONFIG_MSM_GCC_8909) += gcc-msm8909.o
>>  obj-$(CONFIG_MSM_GCC_8916) += gcc-msm8916.o
>>  obj-$(CONFIG_MSM_GCC_8917) += gcc-msm8917.o
>>  obj-$(CONFIG_MSM_GCC_8939) += gcc-msm8939.o
>> +obj-$(CONFIG_MSM_GCC_8952) += gcc-msm8952.o
>>  obj-$(CONFIG_MSM_GCC_8953) += gcc-msm8953.o
>>  obj-$(CONFIG_MSM_GCC_8960) += gcc-msm8960.o
>>  obj-$(CONFIG_MSM_GCC_8974) += gcc-msm8974.o
>> diff --git a/drivers/clk/qcom/gcc-msm8952.c b/drivers/clk/qcom/gcc-msm8952.c
>> new file mode 100644
>> index 000000000000..6b82606dfadb
>> --- /dev/null
>> +++ b/drivers/clk/qcom/gcc-msm8952.c
>> @@ -0,0 +1,3550 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright 2020 Linaro Limited
> 
> https://android.googlesource.com/kernel/msm/+/android-msm-shamrock-3.10-nougat-release/drivers/clk/qcom/clock-gcc-8952.c
> 
> This is our original copyright.
> 
>> + * Copyright 2026 Muzaffer Kadir <muzafferkadir@xxxxxxxxxxxxxx>
>> + */
>> +
>> +#include <linux/kernel.h>
>> +#include <linux/bitops.h>
>> +#include <linux/err.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/module.h>
>> +#include <linux/of.h>
>> +#include <linux/clk-provider.h>
>> +#include <linux/regmap.h>
>> +#include <linux/reset-controller.h>
>> +
>> +#include <dt-bindings/clock/qcom,gcc-msm8952.h>
>> +
>> +#include "common.h"
>> +#include "clk-regmap.h"
>> +#include "clk-pll.h"
>> +#include "clk-alpha-pll.h"
>> +#include "clk-rcg.h"
>> +#include "clk-branch.h"
>> +#include "reset.h"
>> +#include "gdsc.h"
>> +
> 
> Add DT_BI_TCXO enum.

Should I rename the clock name to bi_tcxo?
Or should I use DT_XO for enum?

Best regards,
Muzaffer Kadir