Re: [PATCH v3 2/2] drm/tiny: add support for PIXPAPER 4.26 monochrome e-ink panel

[Javier Martinez Canillas]

Hello Thomas,

On Thu, Sep 17, 2026 at 1:34 PM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
>
> Hi
>
> Am 17.09.26 um 12:49 schrieb Javier Martinez Canillas:

[...]

> > There are a few bits that I think are similar though and could be
> > reused, for example the pixpaper_spi_write() helper logic is basically
> > the same than ssd130x_spi_write() AFAICT.
> >
> > Same for pixpaper_send_cmd() and pixpaper_send_data(), I believe that
> > is the same logic that we now have in ssd130x_write_cmds(). Specially
> > after the recent commit 3e391b0b516b ("drm/ssd130x: Add SSD135X_FAMILY
> > and SSD1351 support") that introduced a cmd_params_are_data flag that
> > allows to send the operation as command and the parameters as data.
> >
> > So the MCU interface seems to be the same, in particular for the
> > 4-wire SPI interface which AFAIU is what this new SSD1677 driver
> > supports.
>
> I cannot advice anything here, but at least I'd like to get ssd16xx out
> of tiny/. It would be great to have it all under solomon/. It looks like
> sitronix/ does a similar thing.
>

Yes, I agree. Especially since there is even some (albeit small) code
that could be reused.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat