[PATCH] mlxsw: spectrum_flower: Fix port range register leak
From: Wentao Liang
Date: Thu Sep 17 2026 - 07:37:25 EST
mlxsw_sp_flower_parse_ports_range() acquires the source port range
register before the destination one. If the destination lookup then
fails, the source register reference is left behind in a partially
filled rule info, and callers that pass a stack allocated rule info
never release it. Release the source register before returning the
error so that the reference is not leaked.
Fixes: fe22f7410527 ("mlxsw: spectrum_flower: Add ability to match on port ranges")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
index 353fd9ca89a6..4cad6c46b07e 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
@@ -486,8 +486,14 @@ mlxsw_sp_flower_parse_ports_range(struct mlxsw_sp *mlxsw_sp,
err = mlxsw_sp_port_range_reg_get(mlxsw_sp, &range,
f->common.extack, &prr_index);
- if (err)
+ if (err) {
+ if (rulei->src_port_range_reg_valid) {
+ mlxsw_sp_port_range_reg_put(mlxsw_sp,
+ rulei->src_port_range_reg_index);
+ rulei->src_port_range_reg_valid = false;
+ }
return err;
+ }
rulei->dst_port_range_reg_index = prr_index;
rulei->dst_port_range_reg_valid = true;
--
2.34.1