Re: [PATCH] fs: fix misleading comments in read_write.c
From: Christian Brauner
Date: Thu Sep 17 2026 - 06:38:07 EST
On Mon, 14 Sep 2026 15:53:37 +0800, Yingchao Deng wrote:
> generic_write_checks() returns the number of bytes that may be written
> (possibly truncated by generic_write_check_limits()), not zero. The
> comment was likely copied from generic_copy_file_checks(), which is the
> analogous function for copy_file_range() and does return 0 on success.
>
> Also, no_seek_end_llseek() and no_seek_end_llseek_size() are helpers for
> files that do not support SEEK_END (they only handle SEEK_SET and
> SEEK_CUR), not for "fixed-sized devices"; that description was copied
> from fixed_size_llseek().
>
> [...]
Applied to the vfs-7.4.misc branch of the vfs/vfs.git tree.
Patches in the vfs-7.4.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-7.4.misc
[1/1] fs: fix misleading comments in read_write.c
https://git.kernel.org/vfs/vfs/c/73a1ab6d7e14