Re: [PATCH 28/30] crypto: sa2ul - route requests through crypto_engine

From: T Pratham

Date: Thu Sep 17 2026 - 06:29:01 EST


On 9/15/26 15:25, Manorit Chawdhry wrote:
[...]
> @@ -914,8 +915,8 @@ static int sa_cipher_cra_init(struct crypto_skcipher *tfm)
> }
>
> ctx->fallback.skcipher = child;
> - crypto_skcipher_set_reqsize(tfm, crypto_skcipher_reqsize(child) +
> - sizeof(struct skcipher_request));
> + crypto_skcipher_set_reqsize(tfm, sizeof(struct sa_cipher_req_ctx) +
> + crypto_skcipher_reqsize(child));
>
Last I remember, crypto_*_set_reqsize() type dynamic reqsize setting was
being deprecated in lieu of cra_reqsize field in the algorithm
registration struct. Should change this to that.

While we are here, also rename the cra_init/cra_exit functions to
init_tfm/exit_tfm as these are no longer associated inside cra.

--
Regards
T Pratham <t-pratham@xxxxxx>