Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Add Xiaomi Mi 8 family compatibles

[Krzysztof Kozlowski]

On Tue, Sep 15, 2026 at 04:32:24PM +0200, David Heidelberg wrote:
> +      - description: Xiaomi Mi 8 family
> +        items:
> +          - enum:
> +              - xiaomi,dipper
> +              - xiaomi,equuleus
> +              - xiaomi,ursa
> +          - const: xiaomi,dipper-common

We do not make "common" compatibles.
git grep common -- Documentation/devicetree/bindings/arm/qcom.yaml

See other examples how this can be named, even one below:

> +          - const: qcom,sdm845
> +
>        - description: Xiaomi Poco F1
>          items:
>            - enum:
>                - xiaomi,beryllium-ebbg
>                - xiaomi,beryllium-tianma
>            - const: xiaomi,beryllium
>            - const: qcom,sdm845

Best regards,
Krzysztof