Re: [PATCH 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: Add AW8695 haptics
From: Konrad Dybcio
Date: Thu Sep 17 2026 - 05:32:14 EST
On 9/14/26 4:37 PM, Griffin Kroah-Hartman wrote:
> From: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
>
> Add a node for the haptics driver found on the phone.
>
> Co-developed-by: Griffin Kroah-Hartman <griffin.kroah@xxxxxxxxxxxxx>
> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@xxxxxxxxxxxxx>
> Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
> ---
[...]
> + aw8695_int_default: aw8695-int-default-state {
> + pins = "gpio85";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> + aw8695_reset_default: aw8695-reset-default-state {
> + pins = "gpio90";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-down;
Shouldn't this be a pull-up if the reset is active-low?
Konrad