Re: [PATCH v14 19/22] KVM: selftests: Finalize TD memory as part of kvm_arch_vm_finalize_vcpus
From: Peter Fang
Date: Thu Sep 17 2026 - 05:23:52 EST
On Tue, Sep 08, 2026 at 04:24:38PM -0700, Ackerley Tng wrote:
> Xiaoyao Li <xiaoyao.li@xxxxxxxxx> writes:
>
> > On 7/23/2026 7:13 AM, Lisa Wang wrote:
> >> From: Sagi Shahar <sagis@xxxxxxxxxx>
> >>
> >> Finalize TDX VM after creation to make it runnable.
> >
> > The changelog is too weak.
> >
>
> Some other points I can think of (Xiaoyao, please add on!):
>
> + Why was kvm_arch_vm_finalize_vcpus() was picked as the lifecycle hook
> in which to finalize the VM? (See comments from the earlier revision
> from Sean) What are the rejected alternatives?
> + Expand on "make it runnable": finalizing also performs measurements
>
> Just confirming: Peter, you meant to add the () at the end of
> kvm_arch_vm_finalize_vcpus in the commit subject, right?
Yep correct
>