[PATCH net 0/2] net: ngbe: fix error handling in resume and open paths

[Zhang Yunfei]

Two error-handling fixes for the ngbe PM/open paths.

ngbe_resume() declared err as u32 and returned 0 unconditionally, so a
failed wx_init_interrupt_scheme() or ngbe_open() left the device in
netif_device_detach() state with a broken interrupt scheme while the PM
core was told the resume succeeded; the reset task bails out on the
missing netif_device_present() check, so the device cannot self-heal.
Patch 1 fixes the type and propagates the error, making the tail of the
resume path consistent with the pci_enable_device_mem() failure path at
the top, which already reports its error.

ngbe_open() sets the WX_CFG_PORT_CTL_DRV_LOAD bit to tell the management
firmware the host has taken over the port, but no error path cleared it,
leaving the firmware owning a port whose rings and IRQs are gone. Patch 2
rolls the bit back on all open error paths, matching ngbe_close() and
ngbe_dev_shutdown().

Zhang Yunfei (2):
  net: ngbe: propagate resume errors to the PM core
  net: ngbe: clear DRV_LOAD bit when ngbe_open() fails

 drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)


base-commit: 587858367581b9c55c3690f4e63382ad622719d4
-- 
2.25.1