Re: [PATCH 2/3] dt-bindings: media: i2c: Add vision-components,mipi-module-controller

From: Krzysztof Kozlowski

Date: Thu Sep 17 2026 - 04:40:23 EST


On 17/09/2026 10:19, Laurent Pinchart wrote:
>>>>> Connector
>>>>> || +--------+
>>>>> || <------------ MIPI CSI-2 ------------ | |
>>>>> || +-------+ | |
>>>>> || <--- I2C ---> | | <--- I2C ---> | Sensor |
>>>>> || | FPGA | | |
>>>>> || | | --- Clock --> | |
>>>>> || +-------+ +--------+
>>>>> ^
>>>>> |
>>>>> +-------+
>>>>> | Clock |
>>>>> | Osc. |
>>>>> +-------+
>>>>>
>>>>> The frequency of the external clock oscillator is what the
>>>>> clock-frequency models.
>>
>> ... this sentence confused me. If the oscillator is part of the module,
>> then clock-frequency property is applicable or it is implied by the
>> compatible.
>
> Our replies have crossed each other. I should have waited, it would have
> saved me time writing a long message :-)
>
> Yes, the external oscillator is in the module. That's why I initially
> proposed using the clock-frequency property. We could still model it as
> a separate DT node (see my other e-mail), but I think it brings
> complexity for little gain.

Yes, I agree.


Best regards,
Krzysztof