Re: [PATCH v4 01/52] dt-bindings: clock: qcom: gcc-sdm845: Add CX power domain

[Krzysztof Kozlowski]

On Mon, Sep 14, 2026 at 03:47:00PM +0300, Abel Vesa wrote:
> Describe the CX power-domain dependency for SDM845 and SDM670 GCCs, and

The domain is already there thus first part "describe ..." is not
accurate. You changed nothing.

> require it for both compatibles.
> 
> Without this dependency, GCC GDSC consumers cannot vote for CX and RPMh may
> undervolt it.
> 
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/clock/qcom,gcc-sdm845.yaml | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sdm845.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sdm845.yaml
> index a7523a414341..356af877353d 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sdm845.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sdm845.yaml
> @@ -31,7 +31,8 @@ properties:
>      maxItems: 5
>  
>    power-domains:
> -    maxItems: 1
> +    items:
> +      - description: CX power domain
>  
>  required:
>    - compatible
> @@ -56,6 +57,8 @@ allOf:
>              - const: bi_tcxo
>              - const: bi_tcxo_ao
>              - const: sleep_clk
> +      required:
> +        - power-domains
>  
>    - if:
>        properties:
> @@ -78,6 +81,8 @@ allOf:
>              - const: sleep_clk
>              - const: pcie_0_pipe_clk
>              - const: pcie_1_pipe_clk
> +      required:
> +        - power-domains

Why is this required per each "if" branch, but not in the top-level?
There are only two compatibles here.

Best regards,
Krzysztof