Re: [PATCH 6/6] usb: cdns3: add missing pm_runtime_dont_use_autosuspend() call

[Peter Chen]

On 26-09-15 09:02:23, Joshua Crofts wrote:
> cdns3_plat_remove() calls pm_runtime_disable() on device teardown, but
> doesn't call pm_runtime_dont_use_autosuspend(), causing resource leaks.

Not a resource leak.

> 
> Add the missing pm_runtime_dont_use_autosuspend() call.
> 
> Found using Coccinelle.
> 
> Fixes: f738957277ba ("usb: cdns3: Split core.c into cdns3-plat and core.c file")
> Cc: <stable@xxxxxxxxxxxxxxx>

Not a big issue, it is not necessary to backport.

Peter

> Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> ---
>  drivers/usb/cdns3/cdns3-plat.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
> index e3f32c3e9535..b85d5d1c48fd 100644
> --- a/drivers/usb/cdns3/cdns3-plat.c
> +++ b/drivers/usb/cdns3/cdns3-plat.c
> @@ -219,6 +219,7 @@ static void cdns3_plat_remove(struct platform_device *pdev)
>  	if (!(cdns->pdata && (cdns->pdata->quirks & CDNS3_DEFAULT_PM_RUNTIME_ALLOW)))
>  		pm_runtime_allow(dev);
>  
> +	pm_runtime_dont_use_autosuspend(dev);
>  	pm_runtime_disable(dev);
>  	pm_runtime_put_noidle(dev);
>  	cdns_remove(cdns);
> -- 
> 2.47.3
> 

-- 

Thanks,
Peter Chen