Re: [PATCH bpf-next v2 03/13] bpf: track low-32 scalar equality across zero-extending movs

[Alexei Starovoitov]

On Wed, Sep 16, 2026 at 5:08 PM Vineet Gupta <vineet.gupta@xxxxxxxxx> wrote:
>
> It ended up with full testsuite run parity - after 4 incremental patches.
> But the pattern of all those patches was adding some predicate /
> special-casing to reg->add_const
>
> hunk 1
>
> -       if (src_reg->add_const)
> +       if (src_reg->add_const && src_reg->delta)

why? It should not.
My point is that zero is not special.
It should be handled within the current framework.
All these extra hunks are not correct.
ADD_CONST_32 logic should work for delta == 0 just like
it works for delta == 1.