Re: [PATCH 08/20] ASoC: audio-graph-card2: Fix device node leaks in graph_count_c2c()

[Kuninori Morimoto]

Hi Wentao

Thank you for your patch

>  	struct device_node *ports	__free(device_node) = port_to_ports(lnk);
> -	struct device_node *port0	= of_node_get(lnk);
> -	struct device_node *port1	= of_node_get(of_graph_get_next_port(ports, of_node_get(port0)));
> +	struct device_node *port0	__free(device_node) = of_node_get(lnk);
> +	struct device_node *port1	__free(device_node) =
> +		of_graph_get_next_port(ports, of_node_get(port0));
>  	struct device_node *ep0		__free(device_node) = of_graph_get_next_port_endpoint(port0, NULL);
>  	struct device_node *ep1		__free(device_node) = of_graph_get_next_port_endpoint(port1, NULL);

Ah, it is confusale part, indeed.
I have confirmed that your code seems correct.

My personally, I like 1 line code for port1

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

Thank you for your help !!

Best regards
---
Kuninori Morimoto