Re: [PATCH net-next] net: fec: gate MPC52xx driver on PPC_MPC52xx

[Rosen Penev]

On Wed, Sep 16, 2026 at 3:09 PM Rosen Penev <rosenp@xxxxxxxxx> wrote:
>
> The FEC MPC52xx driver only applies to the MPC52xx family of SoCs,
> but only depended on PPC_BESTCOMM. Restrict the driver to MPC52xx
> platforms so it is not offered if COMPILE_TEST is applied to
> PPC_BESTCOMM. Otherwise the following errors happen during linking:
>
> ERROR: modpost: drivers/net/ethernet/freescale/fec_mpc52xx.ko: symbol 'mpc5xxx_fwnode_get_bus_frequency' undefined!
> ERROR: modpost: drivers/net/ethernet/freescale/fec_mpc52xx_phy.ko: symbol 'mpc5xxx_fwnode_get_bus_frequency' undefined!
>
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
>  drivers/net/ethernet/freescale/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
> index b34c0fcfddea..d81984fcec64 100644
> --- a/drivers/net/ethernet/freescale/Kconfig
> +++ b/drivers/net/ethernet/freescale/Kconfig
> @@ -38,7 +38,7 @@ config FEC
>
>  config FEC_MPC52xx
>         tristate "FEC MPC52xx driver"
> -       depends on PPC_BESTCOMM
> +       depends on PPC_BESTCOMM && PPC_MPC52xx
oh this is against local changes. Please ignore.
>         select CRC32
>         select PHYLIB
>         select PPC_BESTCOMM_FEC
> --
> 2.55.0
>