Re: [PATCH] powerpc: fsl_rio: Use snprintf() in fsl_rio_setup()
From: Thorsten Blum
Date: Wed Sep 16 2026 - 17:33:11 EST
On Tue, Jun 30, 2026 at 04:49:50PM +0200, Thorsten Blum wrote:
> While the current code works correctly, replace the unbounded sprintf()
> with the safer snprintf() in fsl_rio_setup() to follow secure coding
> best practices.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> ---
> arch/powerpc/sysdev/fsl_rio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Gentle ping?
> diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c
> index eb55dabb4748..077c03cd93e4 100644
> --- a/arch/powerpc/sysdev/fsl_rio.c
> +++ b/arch/powerpc/sysdev/fsl_rio.c
> @@ -612,7 +612,7 @@ static int fsl_rio_setup(struct platform_device *dev)
> kfree(port);
> continue;
> }
> - sprintf(port->name, "RIO mport %d", i);
> + snprintf(port->name, sizeof(port->name), "RIO mport %d", i);
>
> priv->dev = &dev->dev;
> port->dev.parent = &dev->dev;