Re: [PATCH 05/20] ASoC: es9356: Publish IRQ readiness after cache replay

[Mark Brown]

On Fri, Aug 28, 2026 at 07:34:00PM +0800, Pengpeng Hou wrote:
> es9356_sdca_dev_resume() clears its disable_irq software gate before
> waiting for SoundWire initialization and before replaying the register
> cache.  If either operation fails, interrupt work can run against a
> device that did not finish resume.  The cache replay result itself is
> also ignored.

> +	if (!slave->unattach_request)
> +		scoped_guard(mutex, &es9356->disable_irq_lock)
> +			es9356->disable_irq = false;

This breaks the build:

/build/stage/linux/sound/soc/codecs/es9356.c: In function ‘es9356_sdca_dev_resume’:
/build/stage/linux/sound/soc/codecs/es9356.c:1124:12: error: suggest explicit braces to avoid ambiguous ‘else’ [-Werror=dangling-else]
 1124 |         if (!slave->unattach_request)
      |            ^
cc1: all warnings being treated as errors

Attachment: signature.asc
Description: PGP signature