Re: [PATCH] clk: versatile: clk-icst: Fix node reference leak in of_syscon_icst_setup()

[Linus Walleij]

On Tue, Sep 15, 2026 at 9:01 AM Wentao Liang <vulab@xxxxxxxxxxx> wrote:

> of_get_parent() takes a reference on the syscon parent node. The
> reference is intentionally kept on the success path, but the error paths
> return without dropping it, leaking the node reference. Release the
> reference before returning on the error paths.
>
> Fixes: d430819d69a5 ("clk: versatile-icst: add device tree support")
> Cc: stable@xxxxxxxxxxxxxxx

Stable? Really? It's no big deal.

> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij