Re: [PATCH] pinctrl: single: free the IRQ on domain creation failure

[Linus Walleij]

On Sun, Sep 13, 2026 at 6:03 AM Myeonghun Pak <mhun512@xxxxxxxxx> wrote:

> pcs_irq_init_chained_handler() requests a shared IRQ on affected SoCs, but
> its domain creation failure path only removes a chained handler. That does
> not release the action installed by request_irq(). The probe can continue
> without interrupt support while leaving the shared IRQ action registered.
>
> Use pcs_irq_free() to undo the appropriate type of handler registration.
> At this point pcs->domain is NULL, so the helper only releases the parent
> IRQ handler. Then mark the IRQ invalid, as the other initialization error
> paths already do, to prevent another release from a later probe unwind or
> remove.
>
> This issue was identified during our ongoing static-analysis research while
> reviewing kernel code.
>
> Fixes: 3e6cee1786a1 ("pinctrl: single: Add support for wake-up interrupts")
> Cc: stable@xxxxxxxxxxxxxxx
> Assisted-by: OpenAI:GPT-5.6
> Co-developed-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Myeonghun Pak <mhun512@xxxxxxxxx>

Patch applied for fixes.

Yours,
Linus Walleij