[PATCH v10 30/38] selftests: enable comma-terminator tests
From: Jim Cromie via B4 Relay
Date: Wed Sep 16 2026 - 13:01:21 EST
From: Jim Cromie <jim.cromie@xxxxxxxxx>
Enable the FT_comma_terminators test block in dyndbg_selftest.sh to
verify control query parsing when queries are terminated by commas.
Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>
---
.../selftests/dynamic_debug/dyndbg_selftest.sh | 25 ++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index d485b9245164..bd72a718406c 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -347,6 +347,25 @@ function FT_basic_queries {
ddcmd "file $f =_" "$f"
}
+# test parsing on spaces, commas. testing against builtin file kernel/params.c
+function FT_comma_terminators {
+ v_echo "${GREEN}# COMMA_TERMINATOR_TESTS ${NC}"
+ if [ $LACK_DD_BUILTIN -eq 1 ]; then
+ echo "SKIP - test requires dynamic_debug built into kernel"
+ return
+ fi
+ local f='kernel/params.c'
+ ddcmd =_
+ ddcmd "file $f +p" "$f"
+
+ ddcmd "file,$f,=_" "$f"
+ ddcmd "file,$f,+mf" "$f"
+ # ignore empty tokens
+ ddcmd ",file ,, , $f, -p" "$f"
+ ddcmd " , file ,,, , $f, -m" "$f"
+
+ ddcmd =_
+}
# testing classmap-based query enablers and class configurations
function FT_test_classes {
v_echo "${GREEN}# TEST_CLASSES - classmap-based query enablers and class configs ${NC}"
@@ -454,6 +473,7 @@ builtin_tests=(
FT_grammar_ok
FT_grammar_errs
FT_basic_queries
+ FT_comma_terminators
)
# Modular Feature Tests (Require CONFIG_MODULES=y and test_dynamic_debug*.ko available)
@@ -544,6 +564,11 @@ function GOLDEN_RECORDS {
#K= 02e4fd94602e108cb89bfc70d47a5dad FT_basic_queries.5
#K= f03a7ca7316e8db4c0e16523dc41e75d FT_basic_queries.6
#K= c518a50ba30ba8099d0dc874a27ecf16 FT_basic_queries.7
+#K= c8bbbac639f244ed9088208ebb7d83a6 FT_comma_terminators.1
+#K= bed6350f058f600910837dae83a12f56 FT_comma_terminators.2
+#K= 6e8599556a312200fb6d484565b6c52f FT_comma_terminators.3
+#K= 68b329da9893e34099c7d8ad5cb9c940 FT_comma_terminators.4
+#K= adc1ef04304c861c87fe294a8ba4e402 FT_comma_terminators.5
#K= 8f18ea82c09460434b6e9e4cd12543e8 FT_test_classes.1
#K= a15ec4843acd721fbdfddc0b512c8032 FT_test_classes.2
#K= 20d4545f9753e677e72e3adf52527fd3 FT_test_classes.3
--
2.55.0