Re: [PATCH v6 3/4] mfd: intel-lpss: Remove extra DebugFS dentry

[Andy Shevchenko]

On Wed, Sep 16, 2026 at 06:44:59PM +0300, Andy Shevchenko wrote:
> On Wed, Sep 16, 2026 at 07:36:41PM +0500, Maria Lisina wrote:

...

> >  static void intel_lpss_debugfs_add(struct intel_lpss *lpss)
> >  {
> > -	struct dentry *dir;
> > -
> > -	dir = debugfs_create_dir(dev_name(lpss->dev), intel_lpss_debugfs);
> > +	lpss->debugfs = debugfs_create_dir(dev_name(lpss->dev),
> > +					   intel_lpss_debugfs);
> 
> As Lee pointed out, we are fine with 100 limit, so one line here and below.

After addressing this feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> >  	/* Cache the values into lpss structure */
> >  	intel_lpss_cache_ltr(lpss);
> >  
> > -	debugfs_create_x32("capabilities", 0444, dir, &lpss->caps);
> > -	debugfs_create_x32("active_ltr", 0444, dir, &lpss->active_ltr);
> > -	debugfs_create_x32("idle_ltr", 0444, dir, &lpss->idle_ltr);
> > -
> > -	lpss->debugfs = dir;
> > +	debugfs_create_x32("capabilities", 0444,
> > +			   lpss->debugfs, &lpss->caps);
> > +	debugfs_create_x32("active_ltr", 0444,
> > +			   lpss->debugfs, &lpss->active_ltr);
> > +	debugfs_create_x32("idle_ltr", 0444,
> > +			   lpss->debugfs, &lpss->idle_ltr);
> >  }

-- 
With Best Regards,
Andy Shevchenko