Re: [PATCH v6 05/13] arm64: dts: qcom: x1e80100: Add CAMSS block definition

[Bryan O'Donoghue]

On 16/09/2026 16:36, Wenmeng Liu wrote:
> On 9/16/2026 10:59 PM, Bryan O'Donoghue wrote:
> > On 08/09/2026 09:46, Wenmeng Liu wrote:
> > > > +                 <&camcc CAM_CC_CPHY_RX_CLK_SRC>,
> > > I think we should remove the SRC clock.
> > >
> > > Thanks,
> > There's no clock that is derived from this clock, so if we remove it,
> > what is responsible to switch this on ?
>
> This SRC clock has child clocks such as CSIPHY0/1/2/4. The CAMSS driver
> never enables this SRC clock directly, and enabling the child clocks
> will automatically enable the parent through the common clock framework,
> so the SRC clock can be dropped.
>
> Thanks,
> Wenmeng

Yes you're right

static struct clk_branch cam_cc_csiphy0_clk = {
        .halt_reg = 0x150fc,
        .halt_check = BRANCH_HALT,
        .clkr = {
                .enable_reg = 0x150fc,
                .enable_mask = BIT(0),
                .hw.init = &(const struct clk_init_data) {
                        .name = "cam_cc_csiphy0_clk",
                        .parent_hws = (const struct clk_hw*[]) {
                                &cam_cc_cphy_rx_clk_src.clkr.hw,
                        },
                        .num_parents = 1,
                        .flags = CLK_SET_RATE_PARENT,
                        .ops = &clk_branch2_ops,
                },
        },
};

---
bod