Re: [PATCH v13 3/5] media: qcom: camss: Add support for PHY API devices
From: Bryan O'Donoghue
Date: Wed Sep 16 2026 - 11:34:24 EST
On 16/09/2026 14:29, Oleg Keri wrote:
Hi Bryan,
On Tue, Jul 28, 2026 at 10:35:34AM +0100, Bryan O'Donoghue wrote:
Add support for PHY API devicesOne thing I ran into while bringing this up on a Lenovo Yoga Slim 7x
Gen 11 (Glymur, ov08x40 on CSIPHY4, two lanes), with Nihal's Glymur
CAMSS series on top: the two ends of the CAMSS <-> PHY link count lanes
differently, and the CAMSS side silently ends up on the wrong lanes.
The csi2-phy binding numbers data-lanes from 1, and the PHY driver
converts:
/* Convert data-lanes = <1 2 3 4> to bit positions */
csi2phy->stream_cfg.lane_cfg.data[i].pos = data_lanes[i] - 1;
The CAMSS endpoint still takes its data-lanes as 0-based positions;
Resolved here:
https://lore.kernel.org/r/20260906-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v17-5-e2197a3e2551@xxxxxxxxxx
---
bod