Re: [PATCH v2 5/7] usb: dwc3: add xhci-reset-on-resume property for power-loss resume

[Faisal Hassan]

On Thu, Sep 03, 2026, Thinh Nguyen wrote:
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -1420,6 +1424,7 @@ struct dwc3 {
>>  	unsigned		wakeup_configured:1;
>>  	unsigned		suspended:1;
>>  	unsigned		susphy_state:1;
>> +	unsigned		xhci_reset_on_resume:1;
>
> Can you move this after dis_split_quirk and add a blank line to separate
> properties from dwc3 state/config fields?
>
>> --- a/drivers/usb/dwc3/host.c
>> +++ b/drivers/usb/dwc3/host.c
>> @@ -129,7 +129,7 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
>>  int dwc3_host_init(struct dwc3 *dwc)
>>  {
>> -	struct property_entry	props[6];
>> +	struct property_entry	props[7];
>
> This should be 8. There's already a fix patch for this. Hopefully it
> gets picked up soon.

Turns out this whole patch isn't needed -- see my reply to Krishna on
this same thread. xhci-plat already walks the parent device chain for
this property, so I'm dropping this patch and attaching it directly on
dwc3-qcom's own device instead, in the "Support broken suspend for
SA8255P" patch later in the series. Both nits go away with it.

Thanks,
Faisal