Re: [PATCH v2 net-next] ppp_synctty: Use common error handling code in ppp_sync_txmunge()

[Simon Horman]

On Tue, Sep 15, 2026 at 11:23:01AM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Tue, 15 Sep 2026 10:48:11 +0200
> 
> Use an additional label so that a bit of exception handling can be better
> reused at the end of this function implementation.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> 
> v2:
> The application of a known source code transformation pattern could be repeated
> after the commit 8aaeb56aff2a557a88f83ae866da2c91ad247e59 ("ppp_synctty:
> ensure a writeable skb header") was integrated.

I have mixed feelings about this as it seems to be a cleanup
outside of the context of other work [1].

But I believe it is correct and does use the preferred goto label based
cleanup mechanism.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>