Re: [PATCH v5] mfd: intel-lpss: Clean up and modernize DebugFS usage

[Andy Shevchenko]

On Wed, Sep 16, 2026 at 11:27:32AM +0100, Lee Jones wrote:
> On Wed, 16 Sep 2026, Maria Lisina wrote:
> 
> > The DebugFS API is designed to handle errors gracefully.
> > Any explicit checking on return values is considered an anti-pattern.
> > 
> > This patch removes unnecessary error checking and converts
> > intel_lpss_debugfs_add() into a void function.
> > 
> > While at it, this patch also clean ups legacy and deprecated usage
> > of S_IRUGO macro and debugfs_remove_recursive() function.

...

> Why continue if this returns an error?

Because we don't care.

> > +	debugfs_create_x32("capabilities", 0444, lpss->debugfs,
> 
> Does this accept a NULL pointer or an error in parameter 3?

Yes, debugfs is designed to be used without checks.

> > +					   &lpss->caps);

-- 
With Best Regards,
Andy Shevchenko