RE: [PATCH] net: sungem: disable PCI device on remove

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Guangshuo Li <lgs201920130244@xxxxxxxxx>
> Sent: Wednesday, September 16, 2026 7:59 AM
> To: Andrew Lunn <andrew+netdev@xxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Petr
> Machata <petrm@xxxxxxxxxx>; Loktionov, Aleksandr
> <aleksandr.loktionov@xxxxxxxxx>; Keller, Jacob E
> <jacob.e.keller@xxxxxxxxx>; Jijie Shao <shaojijie@xxxxxxxxxx>; Uwe
> Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>; Ruoyu
> Wang <ruoyuw560@xxxxxxxxx>; Guangshuo Li <lgs201920130244@xxxxxxxxx>;
> Jakub Raczynski <j.raczynski@xxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Cc: stable@xxxxxxxxxxxxxxx
> Subject: [PATCH] net: sungem: disable PCI device on remove
> 
> gem_init_one() enables the PCI device with pci_enable_device().
> 
> The probe failure path balances this operation with
> pci_disable_device(). However, after a successful probe,
> gem_remove_one() releases the PCI resources and netdev without
> disabling the PCI device.
> 
> Call pci_disable_device() during removal to balance the successful
> pci_enable_device() call.
> 
> This issue was found by manual code inspection.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
> ---
>  drivers/net/ethernet/sun/sungem.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/sun/sungem.c
> b/drivers/net/ethernet/sun/sungem.c
> index dc5638d105db..6abf4d292802 100644
> --- a/drivers/net/ethernet/sun/sungem.c
> +++ b/drivers/net/ethernet/sun/sungem.c
> @@ -2806,6 +2806,7 @@ static void gem_remove_one(struct pci_dev *pdev)
>  		iounmap(gp->regs);
>  		pci_release_regions(pdev);
>  		free_netdev(dev);
> +		pci_disable_device(pdev);
>  	}
>  }
> 
> --
> 2.43.0

The fix is correct, but please resend targeting the net tree, and document testing.
Please also clarify the practical impact supporting the stable backport request.

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>