Re: [PATCH] drm/panfrost: add missing pm_runtime_dont_use_autosuspend() calls
From: Johan Hovold
Date: Wed Sep 16 2026 - 05:37:03 EST
On Wed, Sep 16, 2026 at 07:50:51AM +0000, Joshua Crofts wrote:
> panfrost_remove() and panfrost_probe() disable PM runtime on teardown or
> failure but don't call the pm_runtime_dont_use_autosuspend() function,
> causing potential resource leaks.
No, as I've explained repeatedly elsewhere, it does not cause any
resource leaks. [1][2]
The autosuspend setting leaks if you will, but that only matters in the
theoretical corner case of someone rebinding a different driver (which
will soon also taint the kernel).
So don't exaggerate the impact, this is essentially just a cleanup,
which is fine in itself.
> Add the missing function calls.
>
> Found using Coccinelle.
>
> Fixes: 5c0c825ae4c6 ("drm/panfrost: Replace DRM driver allocation method with newer one")
> Cc: <stable@xxxxxxxxxxxxxxx>
And it does not need to be backported.
> Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
Johan
[1] https://lore.kernel.org/all/aqpd3viN1UoZBkgL@xxxxxxxxxxxxxxxxxxxx/
[2] https://lore.kernel.org/linux-iio/aow51Nk-cet9qaUQ@xxxxxxxxxxxxxxxxxxxx/