Re: [PATCH] irqchip/qcom-pdc: fix linking against QCOM_SCM firmware

[Krzysztof Kozlowski]

On 15/09/2026 21:59, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> Build testing with SCM disabled or in a loadable module fails
> with a link error:
> 
> s390-linux-ld: drivers/irqchip/qcom-pdc.o: in function `qcom_pdc_probe':
> qcom-pdc.c:(.text+0x18b8): undefined reference to `qcom_scm_is_available'
> qcom-pdc.c:(.text+0x18ce): undefined reference to `qcom_scm_io_writel'
> 
> As QCOM_SCM can already be enabled for compile testing on non-qualcomm
> machines, but is always enabled on Qualcomm Arm kernels, use that
> as the Kconfig dependency and remove the ||COMPILE_TEST check.
> 
> Fixes: 1b852de05f74 ("irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM")
> Fixes: ad01c2b2f291 ("irqchip/qcom-pdc: Configure PDC to pass through mode")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof