Re: [PATCH] printk: Remove console options before decoding the name

From: Tony Lindgren

Date: Wed Sep 16 2026 - 01:48:17 EST


On Wed, Sep 16, 2026 at 08:32:18AM +0300, David Engraf wrote:
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -2646,24 +2646,22 @@ static int __init console_setup(char *str)
> if (_braille_console_setup(&str, &brl_options))
> return 1;
>
> + /* Decode str into name, index, options */
> + options = strchr(str, ',');
> + if (options)
> + *(options++) = 0;
> +

How about update the comment for why it needs to be first?

Maybe something like:

Decode str into options first. The options may contain a ':' used also
for DEVNAME.