[PATCH v3 03/12] ASoC: mediatek: mt8189: Validate MCK ID

From: phucduc . bui

Date: Wed Sep 16 2026 - 01:01:05 EST


From: bui duc phuc <phucduc.bui@xxxxxxxxx>

mt8189_mck_disable() only checks for negative MCK IDs.
Reject IDs outside the valid MCK range as well.

Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control")
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
---

Changes in v3:
- Add Angelo's Reviewed-by tag.

sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c
index 56362c4756c9..7fe9d01006d5 100644
--- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c
+++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c
@@ -675,8 +675,8 @@ int mt8189_mck_disable(struct mtk_base_afe *afe, int mck_id)

dev_dbg(afe->dev, "mck_id: %d.\n", mck_id);

- if (mck_id < 0) {
- dev_err(afe->dev, "mck_id = %d < 0\n", mck_id);
+ if (mck_id >= MT8189_MCK_NUM || mck_id < 0) {
+ dev_err(afe->dev, "mck_id = %d\n", mck_id);
return -EINVAL;
}

--
2.43.0