Re: [PATCH v3 4/6] platform/x86/tuxedo: Fix keyboard LED map ordering

[Aaron Erhardt]

Am 15.09.26 um 15:00 schrieb Ilpo Järvinen:
> On Wed, 26 Aug 2026, Aaron Erhardt wrote:
> 
>> The LED mappings in sirius_16_[iso|ansii]_kbl_map did contain a
>> flipped line that caused LEDs to turn on in the wrong order when
>> counting up the Lamp ID.
>>
>> Cc: stable@xxxxxxxxxxxxxxx
> 
> And the Fixes tag?

I assume this is mainly for the stable maintainers to be able to track down
when the bug was introduced, right? I thought "Fixes:" would only be used for
regression bugs.

The only commit relevant to this is the one that introduced the driver itself:
cfd84b3f419bf0aec60ecddc92c61b539c339ec9

I correct this in the next series.

> 
>> Signed-off-by: Aaron Erhardt <aer@xxxxxxxxxxxxxxxxxxx>
>> ---
>>  drivers/platform/x86/tuxedo/nb04/wmi_ab.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/platform/x86/tuxedo/nb04/wmi_ab.c b/drivers/platform/x86/tuxedo/nb04/wmi_ab.c
>> index 8f1ffca0430d..2b985b030197 100644
>> --- a/drivers/platform/x86/tuxedo/nb04/wmi_ab.c
>> +++ b/drivers/platform/x86/tuxedo/nb04/wmi_ab.c
>> @@ -232,8 +232,8 @@ static const struct tux_kbl_map_entry_t sirius_16_ansii_kbl_map[] = {
>>  	{ 0x2e, { 246000,  67500, 5250 } },
>>  	{ 0x2a, { 269500,  67500, 5250 } },
>>  	{ 0x53, { 294500,  67500, 5250 } },
>> -	{ 0x55, { 311200,  67500, 5250 } },
>> -	{ 0x54, { 327900,  67500, 5250 } },
>> +	{ 0x54, { 311200,  67500, 5250 } },
>> +	{ 0x55, { 327900,  67500, 5250 } },
>>  	{ 0x56, { 344600,  67500, 5250 } },
>>  	{ 0x2b, {  31000,  85500, 5500 } },
>>  	{ 0x14, {  51500,  85500, 5500 } },
>> @@ -337,8 +337,8 @@ static const struct tux_kbl_map_entry_t sirius_16_iso_kbl_map[] = {
>>  	{ 0x2e, { 246000,  67500, 5250 } },
>>  	{ 0x2a, { 269500,  67500, 5250 } },
>>  	{ 0x53, { 294500,  67500, 5250 } },
>> -	{ 0x55, { 311200,  67500, 5250 } },
>> -	{ 0x54, { 327900,  67500, 5250 } },
>> +	{ 0x54, { 311200,  67500, 5250 } },
>> +	{ 0x55, { 327900,  67500, 5250 } },
>>  	{ 0x56, { 344600,  67500, 5250 } },
>>  	{ 0x2b, {  31000,  85500, 5500 } },
>>  	{ 0x14, {  51500,  85500, 5500 } },
>>
>