Re: [PATCH v9 9/9] thermal/drivers/exynos: Select thermal emulation support

[Krzysztof Kozlowski]

On 15/09/2026 06:45, Anand Moon wrote:
> Hi Krzysztof,
> 
> Thanks for your review comments.
> On Mon, 14 Sept 2026 at 12:30, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>
>> On 13/09/2026 16:58, Anand Moon wrote:
>>> Select THERMAL_EMULATION when EXYNOS_THERMAL is enabled, as the Exynos
>>> TMU driver provides thermal emulation support.
>>>
>>> This ensures the thermal emulation framework is enabled whenever the
>>> Exynos TMU driver is built.
>>>
>>> Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
>>> ---
>>>  drivers/thermal/samsung/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
>>> index e1e8035d24fb..7d5590f78185 100644
>>> --- a/drivers/thermal/samsung/Kconfig
>>> +++ b/drivers/thermal/samsung/Kconfig
>>> @@ -4,6 +4,7 @@ config EXYNOS_THERMAL
>>>       depends on THERMAL_OF
>>>       depends on HAS_IOMEM
>>>       default ARCH_EXYNOS
>>> +     select THERMAL_EMULATION
>>
>> No, drivers should not select user visible symbols and also this has
>> absolutely nothing to do with Exynos.
>>
>> NAK
>>
> Many distros do not enable it, so I wanted this selected by default.

As usually in the past you do not respond to actual comments. You did
not address none of the two issues I raised, but instead brought
irrelevant comment about distros. It does not matter what the distros
are doing here. They can disable it on purpose and it will not change my
two points.

This reminds me how in the past reviewing of your code leads to quite
abstract discussions, focusing not on the points reviewer made but some
other irrelevant stuff.

I am done with this patchset, also future versions except maybe NAK.

Best regards,
Krzysztof