Re: [PATCH net-next v8 03/15] dpll: add basic SiTime SiT9531x support

[Ali Rouhi]

Replies inline.

> [Kconfig] The later patches in this series do add the DPLL device and pin
> registration, so the help text matches the final state of the series; should
> the Kconfig entry land with the patch that implements it instead?

The Kconfig and Makefile have to land with the first compilable
module skeleton so that every commit of the series builds standing alone.  We
kept the final help text rather than rewriting the same paragraph mid-series;
until the registration patches land the option only enables the probe/detect
skeleton, which we think is acceptable for a series that is meant to be merged
as a unit.

> the comment block for sit9531x_input_get_regs() describes a function that
> does not exist in this patch [...] Could the comment move to that patch?

Right -- the block belongs to
"dpll: sit9531x: implement input pin state on a DPLL" where the function is
added; it is moved there in v9.