Re: [PATCH v2 2/2] usb: dwc3: host: fix props[] overflow when all quirks are enabled
From: Thinh Nguyen
Date: Fri Sep 11 2026 - 19:13:47 EST
On Sat, Sep 05, 2026, David Collin wrote:
> props[] is sized for exactly the number of properties
> dwc3_host_init() can populate, leaving no slot for the NULL
> terminator property_entries_dup() requires when usb3_lpm_capable,
> usb2_lpm_disable, and the <=3.00a PED quirk are all true. Size
> props[] for one more slot.
>
> Fixes: 8da7644493b4 ("usb: dwc3: Specify maximum number of XHCI interrupters")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: David Collin <davidcollin899@xxxxxxxxx>
> ---
> drivers/usb/dwc3/host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index 74117cbb2f42..cd1e5204ac3a 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -130,7 +130,7 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
>
> int dwc3_host_init(struct dwc3 *dwc)
> {
> - struct property_entry props[6];
> + struct property_entry props[7];
> struct platform_device *xhci;
> int ret, irq;
> int prop_idx = 0;
> --
> 2.55.0
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
Thanks,
Thinh