Re: [PATCH v4] mtd: spinand: cache the last read page to avoid redundant SPI operations
From: Miquel Raynal
Date: Thu Sep 10 2026 - 08:56:40 EST
Hi Zongzhen,
On 10/09/2026 at 04:26:18 GMT, sashiko-bot@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
> - [Critical] Partial page reads with software/host ECC cause silent data corruption on subsequent cache hits due to incomplete cache updates.
> - [Critical] Cache hit logic fails to check the Logical Unit Number (LUN), leading to cross-LUN cache aliasing.
> - [High] Missing cache invalidation on OOB/OTP writes causes cached reads to return clobbered data.
> - [High] Error handling leaves cache valid with uncorrected data on
> non-EBADMSG errors.
These still seem valid :-)
Miquèl