[PATCH v9 31/39] selftests: enable comma-terminator tests
From: Jim Cromie via B4 Relay
Date: Tue Sep 08 2026 - 21:06:31 EST
From: Jim Cromie <jim.cromie@xxxxxxxxx>
Enable the FT_comma_terminators test block in dyndbg_selftest.sh to
verify control query parsing when queries are terminated by commas.
Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>
---
.../selftests/dynamic_debug/dyndbg_selftest.sh | 25 ++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index 89c9cfa23d2c..70da3662a201 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -470,6 +470,25 @@ function FT_hyphen_underscore {
ddcmd =_
}
+# test parsing on spaces, commas. testing against builtin file kernel/params.c
+function FT_comma_terminators {
+ v_echo "${GREEN}# COMMA_TERMINATOR_TESTS ${NC}"
+ if [ $LACK_DD_BUILTIN -eq 1 ]; then
+ echo "SKIP - test requires dynamic_debug built into kernel"
+ return
+ fi
+ local f='kernel/params.c'
+ ddcmd =_
+ ddcmd "file $f +p" "$f"
+
+ ddcmd "file,$f,=_" "$f"
+ ddcmd "file,$f,+mf" "$f"
+ # ignore empty tokens
+ ddcmd ",file ,, , $f, -p" "$f"
+ ddcmd " , file ,,, , $f, -m" "$f"
+
+ ddcmd =_
+}
# testing classmap-based query enablers and class configurations
function FT_test_classes {
v_echo "${GREEN}# TEST_CLASSES - classmap-based query enablers and class configs ${NC}"
@@ -581,6 +600,7 @@ builtin_tests=(
FT_basic_queries
FT_path_module_queries
FT_hyphen_underscore
+ FT_comma_terminators
)
# Modular Feature Tests (Require CONFIG_MODULES=y and test_dynamic_debug*.ko available)
@@ -653,6 +673,11 @@ function GOLDEN_RECORDS {
#K= f2b4f24fece9c55f5a5d28323c2019f8 FT_basic_queries.5
#K= 8c2dd1164fbcefb721345ce62a864a37 FT_basic_queries.6
#K= 4542e1e5e7eadcbe8f90a9c934635618 FT_basic_queries.7
+#K= 78ad5b168d9db27931dfe7dac93143bf FT_comma_terminators.1
+#K= 4a8d6e0468d14659030ef523c6e5a184 FT_comma_terminators.2
+#K= 3c445fb23d701041e920a2a6d2b022c7 FT_comma_terminators.3
+#K= 68b329da9893e34099c7d8ad5cb9c940 FT_comma_terminators.4
+#K= c745b8f58c0557edca58d5a224a09190 FT_comma_terminators.5
#K= 8146f6f983c3a76783c89b78b892ed48 FT_test_classes.1
#K= a15ec4843acd721fbdfddc0b512c8032 FT_test_classes.2
#K= 20d4545f9753e677e72e3adf52527fd3 FT_test_classes.3
--
2.55.0