Re: [PATCH v8 02/14] smp: Enable preemption early in smp_call_function_single()

[Thomas Gleixner]

On Tue, Jun 16 2026 at 19:11, Chuyi Zhou wrote:
> Now smp_call_function_single() disables preemption mainly for the following
> reasons:

s/Now//

Because this describes always the current context so 'Now' is redundant.

> - To protect the per-cpu csd_data from concurrent modification by other
> tasks on the current CPU in the !wait case. For the wait case,
> synchronization is not a concern as on-stack csd is used.

Please format bullet points so that they are readable

   - To protect the per-cpu csd_data from concurrent modification by
     other tasks on the current CPU in the !wait case. For the wait
     case, synchronization is not a concern as on-stack csd is used.

...

> - To prevent the remote online CPU from being offlined. Specifically, we
> want to ensure that no new IPIs are queued after smpcfd_dying_cpu() has
> finished.

s/we want to ensure/to ensure/

Changelogs want to be written in passive voice. See Documentation.

> Disabling preemption for the entire execution is unnecessary, especially
> csd_lock_wait() part does not require preemption protection. This patch

especially the csd_lock_wait() invocation at the end of the
execution....

s/This patch enables/Enable/

See Documentation.