Re: [PATCH] binder: synchronize Rust Binder stats with freeze commands

[Greg KH]

On Tue, Jun 16, 2026 at 01:47:37AM +0530, syncrain wrote:
> From: Keshav Verma <iganschel@xxxxxxxxx>
> 
> Rust Binder stats use BC_COUNT and BR_COUNT to size the command and
> return counters, and use event string tables when printing debug
> statistics.
> 
> The Binder protocol includes freeze-related commands and return codes,
> but the Rust Binder statistics code was not updated to cover them. As a
> result, those commands and return codes are not accounted for or printed
> by the stats debug output.
> 
> Update the counts and event string tables so these commands and return
> codes are included in the debug statistics output.
> 
> Signed-off-by: Keshav Verma <iganschel@xxxxxxxxx>
> ---
>  drivers/android/binder/rust_binder_events.c | 7 ++++++-
>  drivers/android/binder/stats.rs             | 4 ++--
>  2 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/android/binder/rust_binder_events.c b/drivers/android/binder/rust_binder_events.c
> index 488b1470060c..5792aa59cc82 100644
> --- a/drivers/android/binder/rust_binder_events.c
> +++ b/drivers/android/binder/rust_binder_events.c
> @@ -28,6 +28,9 @@ const char * const binder_command_strings[] = {
>  	"BC_DEAD_BINDER_DONE",
>  	"BC_TRANSACTION_SG",
>  	"BC_REPLY_SG",
> +	"BC_REQUEST_FREEZE_NOTIFICATION",
> +	"BC_CLEAR_FREEZE_NOTIFICATION",
> +	"BC_FREEZE_NOTIFICATION_DONE",
>  };
>  
>  const char * const binder_return_strings[] = {
> @@ -51,7 +54,9 @@ const char * const binder_return_strings[] = {
>  	"BR_FAILED_REPLY",
>  	"BR_FROZEN_REPLY",
>  	"BR_ONEWAY_SPAM_SUSPECT",
> -	"BR_TRANSACTION_PENDING_FROZEN"
> +	"BR_TRANSACTION_PENDING_FROZEN",
> +	"BR_FROZEN_BINDER",
> +	"BR_CLEAR_FREEZE_NOTIFICATION_DONE",
>  };
>  
>  #define CREATE_TRACE_POINTS
> diff --git a/drivers/android/binder/stats.rs b/drivers/android/binder/stats.rs
> index ab75e9561cbf..ec81dc7747db 100644
> --- a/drivers/android/binder/stats.rs
> +++ b/drivers/android/binder/stats.rs
> @@ -8,8 +8,8 @@
>  use kernel::sync::atomic::{ordering::Relaxed, Atomic};
>  use kernel::{ioctl::_IOC_NR, seq_file::SeqFile, seq_print};
>  
> -const BC_COUNT: usize = _IOC_NR(BC_REPLY_SG) as usize + 1;
> -const BR_COUNT: usize = _IOC_NR(BR_TRANSACTION_PENDING_FROZEN) as usize + 1;
> +const BC_COUNT: usize = _IOC_NR(BC_FREEZE_NOTIFICATION_DONE) as usize + 1;
> +const BR_COUNT: usize = _IOC_NR(BR_CLEAR_FREEZE_NOTIFICATION_DONE) as usize + 1;
>  
>  pub(crate) static GLOBAL_STATS: BinderStats = BinderStats::new();
>  
> -- 
> 2.39.5
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot